Change in vdsm[master]: compat: Use simplejson instead of json

fromani at redhat.com fromani at redhat.com
Mon Nov 16 08:28:03 UTC 2015


Francesco Romani has posted comments on this change.

Change subject: compat: Use simplejson instead of json
......................................................................


Patch Set 5:

(1 comment)

codewise, I'm fine. From packaging point of view, this can give us some headaches. Please see inline comments.

https://gerrit.ovirt.org/#/c/48565/5/automation/check-patch.packages
File automation/check-patch.packages:

Line 16: python-nose
Line 17: python-pep8
Line 18: python-pthreading
Line 19: python-six
Line 20: python-simplejson
on el7 AFAIK python-simplejson comes from EPEL, and this is no good for RHEL (EPEL is unsupported).

This is because python 2.7 has updated json package in the stdlib, while python 2.6 relied on python-simplejson.

Catch-22?
Line 21: rpm-build
Line 22: sudo
Line 23: yum


-- 
To view, visit https://gerrit.ovirt.org/48565
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2f0fb2ac45da86a344be556e6474667650bca966
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list