Change in vdsm[master]: v2v: add fake virt-v2v process for testing without virt-v2v

nsoffer at redhat.com nsoffer at redhat.com
Sun Nov 15 22:56:41 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: v2v: add fake virt-v2v process for testing without virt-v2v
......................................................................


Patch Set 10:

(1 comment)

Shahahr, I rebased this on the thread-names branch, trying to verify  the thread-names change using the new test. Unfortunately, you don't run the job normally (using start()), so it does not help to test the thread change.

Feel free to rebase back on master.

https://gerrit.ovirt.org/#/c/47738/10/tests/v2vTests.py
File tests/v2vTests.py:

Line 328:             Do not change this parameters without modifying
Line 329:             fake-virt-v2v.output.
Line 330:         '''
Line 331:         self.ivm._import()
Line 332:         self.assertEqual(self.ivm.status, v2v.STATUS.DONE)
This part may break and cause this test to break while there is nothing wrong
with the tool. We want a simple test that test *only* the fake-virt-v2v tool.

I commented about it more then once but it seems that you did not understand what I mean. I uploaded a draft showing how this test should be implemented:
https://gerrit.ovirt.org/47738

If you agree that this is the way to go, please squash that draft with your patch.
Line 333: 
Line 334:         rc, output, error = execCmd(self.ivm._from_libvirt_command(), raw=True)
Line 335:         self.assertEqual(rc, 0)
Line 336: 


-- 
To view, visit https://gerrit.ovirt.org/47738
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If062a1136921af19a2ffcb4d147611bbc9cf5464
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list