Change in vdsm[master]: hsm : Do not resize on Disconnect Storage Server

amureini at redhat.com amureini at redhat.com
Sun Nov 15 15:44:57 UTC 2015


Allon Mureinik has posted comments on this change.

Change subject: hsm : Do not resize on Disconnect Storage Server
......................................................................


Patch Set 1:

(4 comments)

https://gerrit.ovirt.org/#/c/48578/1//COMMIT_MSG
Commit Message:

Line 8: 
Line 9: When a host is moved to maintenance state, it will
Line 10: disconnect from the connected storage servers.
Line 11: 
Line 12: Then, the sd cache refreshStorage is called. It will rescan
either "the sd cache's refrshStorage method" or "sdCache.refreshStorage()".
Line 13: the devices, and an attempt to resize them is performed.
Line 14: 
Line 15: However,in case of disconnectStorageServer flow, resizing
Line 16: devices is not needed and may cause exceptions when trying


Line 11: 
Line 12: Then, the sd cache refreshStorage is called. It will rescan
Line 13: the devices, and an attempt to resize them is performed.
Line 14: 
Line 15: However,in case of disconnectStorageServer flow, resizing
Missing whitespace after the comma.
Line 16: devices is not needed and may cause exceptions when trying
Line 17: to access sysfs when the iscsi connections are being removed.
Line 18: 
Line 19: Change-Id: I78e236a851b7a0e9ab8f3c86e180cc50fde4ad56


Line 13: the devices, and an attempt to resize them is performed.
Line 14: 
Line 15: However,in case of disconnectStorageServer flow, resizing
Line 16: devices is not needed and may cause exceptions when trying
Line 17: to access sysfs when the iscsi connections are being removed.
... and needlessly delay the maintenance operation.
Line 18: 
Line 19: Change-Id: I78e236a851b7a0e9ab8f3c86e180cc50fde4ad56
Line 20: Bug-Url: https://bugzilla.redhat.com/1281909


https://gerrit.ovirt.org/#/c/48578/1/vdsm/storage/sdc.py
File vdsm/storage/sdc.py:

Line 79:     @misc.samplingmethod
Line 80:     def refreshStorage(self, resize=True):
Line 81:         self.__staleStatus = self.STORAGE_REFRESHING
Line 82: 
Line 83:         multipath.rescan()
Probably not a part of this patch - but do we really want to rescan multipath when we disconnect?
Line 84:         if resize:
Line 85:             multipath.resize_devices()
Line 86:         lvm.invalidateCache()
Line 87: 


-- 
To view, visit https://gerrit.ovirt.org/48578
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I78e236a851b7a0e9ab8f3c86e180cc50fde4ad56
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Fred Rolland <frolland at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list