Change in vdsm[master]: hooks: ovs: set OVS devices UP

ibarkan at redhat.com ibarkan at redhat.com
Sun Nov 15 07:51:57 UTC 2015


Ido Barkan has posted comments on this change.

Change subject: hooks: ovs: set OVS devices UP
......................................................................


Patch Set 3: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/48388/3/vdsm_hooks/ovs/ovs_before_network_setup.py
File vdsm_hooks/ovs/ovs_before_network_setup.py:

Line 147: evices.add(BRIDGE_NAME)
I don't know. Does the main bridge up necessary only if devices isn't empty? for example if we had X and Y and Y was removed? no way that X is now down after we finished messing with the bridge?
Maybe setting everything up if we touched something is a good idea?


-- 
To view, visit https://gerrit.ovirt.org/48388
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia8af77c136a8f27d980f94647f78570b3da1e611
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list