Change in vdsm[master]: virt: Make BIOS messages available on vmconsole
fromani at redhat.com
fromani at redhat.com
Thu Nov 12 17:19:13 UTC 2015
Francesco Romani has posted comments on this change.
Change subject: virt: Make BIOS messages available on vmconsole
......................................................................
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/48404/3/vdsm/virt/vmxml.py
File vdsm/virt/vmxml.py:
Line 230: self.dom.setAttr('xmlns:' + METADATA_VM_TUNE_PREFIX,
Line 231: METADATA_VM_TUNE_URI)
Line 232: self.dom.appendChild(self._metadata)
Line 233:
Line 234: def appendOs(self, serial_console_available=False):
I'd go for the shorter and equally expressive
'bios_use_serial'
Line 235: """
Line 236: Add <os> element to domain:
Line 237:
Line 238: <os>
--
To view, visit https://gerrit.ovirt.org/48404
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc560d2562a913b7dba9a5c01952429459595973
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list