Change in vdsm[master]: build: Cleanup conditionals in the build system

nsoffer at redhat.com nsoffer at redhat.com
Wed Nov 11 22:01:24 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: build: Cleanup conditionals in the build system
......................................................................


Patch Set 3:

(6 comments)

https://gerrit.ovirt.org/#/c/48446/3/configure.ac
File configure.ac:

Line 77
Line 78
Line 79
Line 80
Line 81
koji_build


Line 79
Line 80
Line 81
Line 82
Line 83
--enable-koji-build


Line 83
Line 84
Line 85
Line 86
Line 87
enable_koji_build


Line 52:     )],
Line 53:     ,
Line 54:     [enable_hooks="no"]
Line 55: )
Line 56: AC_SUBST([BUILD_HOOKS], ["${enable_hooks}"])
I don't think we need "build" here, lets keep it only for rhev/koji
Line 57: 
Line 58: AC_ARG_ENABLE(
Line 59:     [gluster-mgmt],
Line 60:     [AS_HELP_STRING(


Line 85:     )],
Line 86:     ,
Line 87:     [enable_koji="no"]
Line 88: )
Line 89: AC_SUBST([KOJI_BUILD], ["${enable_koji}"])
enable_koji_build
Line 90: 
Line 91: AC_ARG_ENABLE(
Line 92:     [libvirt-sanlock],
Line 93:     [AS_HELP_STRING(


https://gerrit.ovirt.org/#/c/48446/3/lib/vdsm/constants.py.in
File lib/vdsm/constants.py.in:

Line 22: 
Line 23: from __future__ import absolute_import
Line 24: import os
Line 25: 
Line 26: GLUSTER_MGMT_ENABLED = False if '@GLUSTER_MGMT@' == 'no' else True
This is so much nicer!

But now that we have "yes", we should do:

    GLUSTER_MGMT_ENABLED = True if "@GLUSTER_MGMT@" == "yes" else False
Line 27: 
Line 28: # VDSM management networks
Line 29: LEGACY_MANAGEMENT_NETWORKS = ('ovirtmgmt', 'rhevm')
Line 30: 


-- 
To view, visit https://gerrit.ovirt.org/48446
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9c94d206eb94ba51752423831ce4e01214a6a6d3
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Barak Korren <bkorren at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list