Change in vdsm[master]: mkimage: lib: add and use umaskset helper
nsoffer at redhat.com
nsoffer at redhat.com
Wed Nov 11 19:16:50 UTC 2015
Nir Soffer has posted comments on this change.
Change subject: mkimage: lib: add and use umaskset helper
......................................................................
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/48133/2/vdsm/mkimage.py
File vdsm/mkimage.py:
Line 123: dirname = tempfile.mkdtemp()
Line 124: _decodeFilesIntoDir(files, dirname)
Line 125: isopath = _getFileName(vmId, files)
Line 126:
Line 127: command = [
> have you considered calling
Mixing fork() and threads is bad idea in general, and in particular in Python:
- http://bugs.python.org/issue22697 - simple example
- http://bugs.python.org/issue6721 - long read, worth it
We do log from execCmd - very easy to deadlock.
Line 128: EXT_UMASKSET, _UMASK, EXT_MKISOFS, '-R', '-J', '-o', isopath
Line 129: ]
Line 130: if volumeName is not None:
Line 131: command.extend(['-V', volumeName])
--
To view, visit https://gerrit.ovirt.org/48133
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6cecb972405a385af8b19542780682eeb394fd12
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list