Change in vdsm[master]: vdsm: introduce cpuinfo module

mpolednik at redhat.com mpolednik at redhat.com
Wed Nov 11 13:06:14 UTC 2015


Martin Polednik has posted comments on this change.

Change subject: vdsm: introduce cpuinfo module
......................................................................


Patch Set 11:

(1 comment)

https://gerrit.ovirt.org/#/c/46912/11/lib/vdsm/utils.py
File lib/vdsm/utils.py:

Line 773: 
Line 774:     __hostUUID = None
Line 775: 
Line 776:     try:
Line 777:         from . import cpuinfo
> why here and not at the top level? Do we have a circular dependency?
We do, cpuinfo requires memoized from utils while this method requires cpuinfo.
Line 778:         if os.path.exists(constants.P_VDSM_NODE_ID):
Line 779:             with open(constants.P_VDSM_NODE_ID) as f:
Line 780:                 __hostUUID = f.readline().replace("\n", "")
Line 781:         else:


-- 
To view, visit https://gerrit.ovirt.org/46912
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa702b05f3825ebdcfed16d86d39a8c38fcf224c
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list