Change in vdsm[master]: gluster: Set mount path based on gluster volume info

nsoffer at redhat.com nsoffer at redhat.com
Tue Nov 10 20:40:13 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: gluster: Set mount path based on gluster volume info
......................................................................


Patch Set 7: Code-Review-1

(1 comment)

Nice, just one space missing.

https://gerrit.ovirt.org/#/c/48308/7/vdsm/storage/storageServer.py
File vdsm/storage/storageServer.py:

Line 340:         self.log.debug("Using bricks: %s", servers)
Line 341:         if self._volfileserver in servers:
Line 342:             servers.remove(self._volfileserver)
Line 343:         else:
Line 344:             self.log.warning("gluster server %r is not in bricks %s, possibly"
This should end with space - current this will log this:

    gluster server %r is not in bricks %s, possiblymounting duplicate servers
Line 345:                              "mounting duplicate servers",
Line 346:                              self._volfileserver, servers)
Line 347: 
Line 348:         if not servers:


-- 
To view, visit https://gerrit.ovirt.org/48308
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id3386b37cd407c52e1b8f38d54c236bffc143e2f
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list