Change in vdsm[master]: gluster: Set mount path based on gluster volume info

ahino at redhat.com ahino at redhat.com
Tue Nov 10 16:14:32 UTC 2015


Ala Hino has posted comments on this change.

Change subject: gluster: Set mount path based on gluster volume info
......................................................................


Patch Set 5:

(2 comments)

https://gerrit.ovirt.org/#/c/48308/5/vdsm/storage/storageServer.py
File vdsm/storage/storageServer.py:

Line 336:             raise se.UnsupportedGlusterVolumeReplicaCountError(replicaCount)
Line 337: 
Line 338:     def _get_backup_servers_option(self):
Line 339:         servers = [brick.split(":")[0] for brick in self.volinfo['bricks']]
Line 340:         self.log.info("backup servers returned from volinfo are %s", servers)
> This log is falsy, these are not the backup server, but the bricks. Also, k
Done
Line 341:         if self._volfileserver in servers:
Line 342:             servers.remove(self._volfileserver)
Line 343:         else:
Line 344:             self.log.warn("gluster server %r not in bricks, possibly mounting"


Line 340:         self.log.info("backup servers returned from volinfo are %s", servers)
Line 341:         if self._volfileserver in servers:
Line 342:             servers.remove(self._volfileserver)
Line 343:         else:
Line 344:             self.log.warn("gluster server %r not in bricks, possibly mounting"
> I would like to see the list of bricks in this log message. When I see a wa
Done
Line 345:                           "duplicate servers", self._volfileserver)
Line 346: 
Line 347:         if not servers:
Line 348:             return ""


-- 
To view, visit https://gerrit.ovirt.org/48308
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id3386b37cd407c52e1b8f38d54c236bffc143e2f
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list