Change in vdsm[master]: lib: executor: make possible to name work tasks

fromani at redhat.com fromani at redhat.com
Tue Nov 10 12:03:49 UTC 2015


Francesco Romani has posted comments on this change.

Change subject: lib: executor: make possible to name work tasks
......................................................................


Patch Set 5:

(2 comments)

https://gerrit.ovirt.org/#/c/48191/5/lib/vdsm/executor.py
File lib/vdsm/executor.py:

Line 184
Line 185
Line 186
Line 187
Line 188
> Here - we log the task - don't we get good logs from this?
we do, if callable raises.
But what if the callable is just stuck (inside qemu, maybe)?
In that case we see that one worker is replaced. Fine. But seeing at glance what the worker was doing - instead of backtracking in the logs, it is a blessing for debugging.


Line 211:         if self._discarded:
Line 212:             raise AssertionError("Attempt to discard worker twice")
Line 213:         self._discarded = True
Line 214:         self._log.debug("Worker %s discarded while doing '%s'",
Line 215:                         self.name, self._task_name)
> Cant we log the task? if you want better debugging, use a callable with __s
that can work, yes. Let me try.
Line 216:         self._executor._worker_discarded(self)
Line 217: 
Line 218: 
Line 219: class TaskQueue(object):


-- 
To view, visit https://gerrit.ovirt.org/48191
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I40584ee9a99839a4cb56d2f4d908d274f3a46638
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list