Change in vdsm[master]: bonding defaults: for validation, we need to be aware of all...

danken at redhat.com danken at redhat.com
Tue Nov 10 09:42:54 UTC 2015


Dan Kenigsberg has submitted this change and it was merged.

Change subject: bonding defaults: for validation, we need to be aware of all options
......................................................................


bonding defaults: for validation, we need to be aware of all options

In the commit b01a096a, we started to use our bonding defaults database
to validate bonding options (by name).  'primary' was not recognized as
a bonding option because its default value is empty.  This patch adds
the rest of valid, but initially empty, options, plus three new ones.

ad_actor_sys_prio, ad_actor_system and ad_user_port_key have recently
been added to the upstream kernel.  primary and arp_ip_target are
empty by default.

Change-Id: Ie2bbd778bb151e4671cc5d3d70ce898e48125331
Bug-Url: https://bugzilla.redhat.com/1262496
Backport-To: 3.6
Signed-off-by: Ondřej Svoboda <osvoboda at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/48008
Continuous-Integration: Jenkins CI
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M lib/vdsm/tool/dump_bonding_defaults.py
M tests/functional/networkTests.py
M vdsm/bonding-defaults.json
3 files changed, 46 insertions(+), 5 deletions(-)

Approvals:
  Ondřej Svoboda: Verified
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/48008
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie2bbd778bb151e4671cc5d3d70ce898e48125331
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: automation at ovirt.org


More information about the vdsm-patches mailing list