Change in vdsm[master]: gluster: Set mount path based on gluster volume info

ahino at redhat.com ahino at redhat.com
Tue Nov 10 09:41:23 UTC 2015


Ala Hino has posted comments on this change.

Change subject: gluster: Set mount path based on gluster volume info
......................................................................


Patch Set 2:

(3 comments)

https://gerrit.ovirt.org/#/c/48308/2/tests/storageServerTests.py
File tests/storageServerTests.py:

Line 148:         self.assertEquals(gluster.options,
Line 149:                           "backup-volfile-servers=192.168.122.2:192.168.122.3")
Line 150: 
Line 151:     @MonkeyPatch(storageServer, 'supervdsm', FakeSupervdsm())
Line 152:     def test_gluster_mount_options_when_gluster_provided_server_not_in_volinfo(self):
> This name his way too long - this break the test report visually.
Done
Line 153:         def glusterVolumeInfo(volname=None, volfileServer=None):
Line 154:             return {'music': {'brickCount': '3',
Line 155:                               'bricks': ['192.168.122.5:/tmp/music',
Line 156:                                          '192.168.122.2:/tmp/music',


https://gerrit.ovirt.org/#/c/48308/2/vdsm/storage/storageServer.py
File vdsm/storage/storageServer.py:

Line 310
Line 311
Line 312
Line 313
Line 314
> Keep the old code for now.
Done


Line 337:             raise se.UnsupportedGlusterVolumeReplicaCountError(replicaCount)
Line 338: 
Line 339:     def _get_backup_servers_option(self):
Line 340:         servers = [brick.split(":")[0] for brick in self.volinfo['bricks']]
Line 341:         self._volfileserver = servers.pop(0)
> There is a major issue with this change.
Waiting Sahina's input.
Meanwhile, changed impl as described.
Line 342:         if not servers:
Line 343:             return ""
Line 344: 
Line 345:         return "backup-volfile-servers=" + ":".join(servers)


-- 
To view, visit https://gerrit.ovirt.org/48308
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id3386b37cd407c52e1b8f38d54c236bffc143e2f
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list