Change in vdsm[master]: gluster: Added VDSM verb to stop gluster related processes

rnachimu at redhat.com rnachimu at redhat.com
Tue Nov 10 06:18:57 UTC 2015


Ramesh N has posted comments on this change.

Change subject: gluster: Added VDSM verb to stop gluster related processes
......................................................................


Patch Set 4:

(2 comments)

https://gerrit.ovirt.org/#/c/43821/4/vdsm/gluster/api.py
File vdsm/gluster/api.py:

Line 274: @makePublic
Line 275: def stopProcesses():
Line 276:     command = ["/bin/sh", _stopAllProcessesPath.cmd]
Line 277:     rc, out, err = utils.execCmd(command)
Line 278:     if rc:
> Looking at the schema file I can see that we return true or false depending
Looks like all gluster functions are returning exceptions instead of false. We have to fix all of them and that requires change in the engine as well. Can we live with exceptions for the time being?.
Line 279:         raise ge.GlusterStopProcessesFailedException(rc)
Line 280:     return True
Line 281: 
Line 282: 


Line 771: stopProcesses(sel
> Please change the name as ProcessesStop to be consistent with other verbs. 
Done. Changed this to ProcessesStop in all the places.


-- 
To view, visit https://gerrit.ovirt.org/43821
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id686e098b323eededcf1f89de331a1d524274995
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shubhendu Tripathi <shtripat at redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga at redhat.com>
Gerrit-Reviewer: Darshan Narayana Murthy <dnarayan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Ramesh N <rnachimu at redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose at redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtripat at redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list