Change in vdsm[master]: migration: Add support for max migration bandwidth setting

fromani at redhat.com fromani at redhat.com
Mon Nov 9 20:13:25 UTC 2015


Francesco Romani has posted comments on this change.

Change subject: migration: Add support for max migration bandwidth setting
......................................................................


Patch Set 8: Code-Review-1

(3 comments)

two minor nits in the schema, should be trivial to fix. Otherwise seems fine. -1 for visibility.

https://gerrit.ovirt.org/#/c/46846/8/vdsm/rpc/vdsmapi-schema.json
File vdsm/rpc/vdsmapi-schema.json:

Line 7708: # @compressed:      #optional Compress repeated pages during live migration.
Line 7709: #                   (new in version 4.17.0)
Line 7710: #
Line 7711: # @autoConverge:    #optional Force convergence during live migration.
Line 7712: #                   (new in version 4.17.0)
please add a newline here
Line 7713: # @maxBandwidth:    #optional maximal bandwidth used by the migration (MiB/s)
Line 7714: #                   ((new in version 4.18.0)
Line 7715: #
Line 7716: # Since: 4.10.0


Line 7710: #
Line 7711: # @autoConverge:    #optional Force convergence during live migration.
Line 7712: #                   (new in version 4.17.0)
Line 7713: # @maxBandwidth:    #optional maximal bandwidth used by the migration (MiB/s)
Line 7714: #                   ((new in version 4.18.0)
spurious extra (
Line 7715: #
Line 7716: # Since: 4.10.0
Line 7717: ##
Line 7718: {'type': 'MigrateParams',


https://gerrit.ovirt.org/#/c/46846/8/vdsm/virt/migration.py
File vdsm/virt/migration.py:

Line 94:         self._downtime = kwargs.get('downtime') or \
Line 95:             config.get('vars', 'migration_downtime')
Line 96:         self._maxBandwidth = int(
Line 97:             kwargs.get('maxBandwidth') or
Line 98:             config.getint('vars', 'migration_max_bandwidth')
note to self: for a (far) future patch:
let's move all the migration* tunables on a separate section.
Line 99:         )
Line 100:         self._autoConverge = autoConverge
Line 101:         self._compressed = compressed
Line 102:         self.status = {


-- 
To view, visit https://gerrit.ovirt.org/46846
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9d99e488a9e8bb80b0c3c069628171c666f3bf4b
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list