Change in vdsm[master]: sp: Allow attaching hosted engine sd

nsoffer at redhat.com nsoffer at redhat.com
Mon Nov 9 17:12:06 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: sp: Allow attaching hosted engine sd
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/48217/1//COMMIT_MSG
Commit Message:

Line 8: 
Line 9: When attaching hosted engine storage domain, sanlock is already
Line 10: maintaining a lockspace on the domain, and releasing the host id would
Line 11: cause sanlock to kill the hosted engine vm.
Line 12: 
> Does Sanlock kill the hosted engine VM or does it kill vdsm on the host?  I
According to Roy, sanlock is killing the qemu process running the hosted engine vm.

It seems that hosted engine vm and vdsm are sharing the same lockspace (where host ids are registered). Vdsm may keep a resource in for the domain lock, and hosted engine is keeping a resource for the engine vm. When you release the host id, sanlock is releasing the reosurces associated with the same lockspace, and the vm is killed.

I'm not sure if vdsm did create the host id used by hosted engine - if this is 
the case, than using reference counting on the cluster lock would solve this issue as well.
Line 13: Now we acquire and release the host id during attach only if needed,
Line 14: keeping hosted engine vm alive.
Line 15: 
Line 16: Change-Id: Ia2fc1b19a6e70d4001a8f6d8c14bae7f65d0c192


-- 
To view, visit https://gerrit.ovirt.org/48217
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia2fc1b19a6e70d4001a8f6d8c14bae7f65d0c192
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list