Change in vdsm[master]: tests: FakeLVM test command failure

nsoffer at redhat.com nsoffer at redhat.com
Mon Nov 9 16:44:20 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: tests: FakeLVM test command failure
......................................................................


Patch Set 7: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/47864/7/tests/storagefakelib.py
File tests/storagefakelib.py:

Line 118:                      opened=False,
Line 119:                      active=bool(activate))
Line 120: 
Line 121:         try:
Line 122:             lv_count = int(self.vgmd[vgName]['lv_count']) + 1
This still hides missing 'lv_count' key, will raise se.CannotCreateLogicalVolume, as if the vg does not exists.

Please separate modification and access. This line is doing too much.
Line 123:         except KeyError:
Line 124:             raise se.CannotCreateLogicalVolume(vgName, lvName)
Line 125: 
Line 126:         if (vgName, lvName) in self.lvmd:


-- 
To view, visit https://gerrit.ovirt.org/47864
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I954b750d744df0dbd9b7ac13138731d80db54bb8
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list