Change in vdsm[ovirt-3.6.0]: Adding call to configure passwd (libvirt sasl password)

ybronhei at redhat.com ybronhei at redhat.com
Sun Nov 8 07:48:10 UTC 2015


Hello Dan Kenigsberg,

I'd like you to do a code review.  Please visit

    https://gerrit.ovirt.org/48231

to review the following change.

Change subject: Adding call to configure passwd (libvirt sasl password)
......................................................................

Adding call to configure passwd (libvirt sasl password)

Between vdsm 4.16 vdsm used the user vdsm at rhevh as sasl user to 
communicate with libvirt. Since Vdsm 4.17 we use vdsm at ovirt user
and therefore need to reconfigure passwd. In 4.17 we moved the
 place where we configure sasl password to vdsm-tool. 
This patch call manually to passwd configurator during init
 phase to avoid upgrade errors.

Change-Id: Ied7346f8d6db0acd38c51bc68167bacbbba9c657
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1276736
Signed-off-by: Yaniv Bronhaim <ybronhei at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/48222
Continuous-Integration: Jenkins CI
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M init/vdsmd_init_common.sh.in
1 file changed, 4 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/31/48231/1

diff --git a/init/vdsmd_init_common.sh.in b/init/vdsmd_init_common.sh.in
index 8dccec4..a6c9bec 100644
--- a/init/vdsmd_init_common.sh.in
+++ b/init/vdsmd_init_common.sh.in
@@ -261,7 +261,10 @@
              ret=$?
         elif grep -q '^vdsm-4\.16\.' "${upgraded_ver_file}"; then
              # REQUIRED_FOR upgrade from vdsm-4.16.z
-             "$VDSM_TOOL" configure --module multipath
+	     # Both mutlipath and sasl password were configured in 4.16 as
+	     # part of the installation - see vdsm-4.16 spec. Since 4.17 the
+	     # logic moved to vdsm-tool
+             "$VDSM_TOOL" configure --module multipath --module passwd
              ret=$?
         fi
         [ "${ret}" -eq 0 ] && rm -f "${upgraded_ver_file}"


-- 
To view, visit https://gerrit.ovirt.org/48231
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ied7346f8d6db0acd38c51bc68167bacbbba9c657
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6.0
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>


More information about the vdsm-patches mailing list