Change in vdsm[master]: tests: FakeLVM add lvPath test
nsoffer at redhat.com
nsoffer at redhat.com
Sat Nov 7 08:43:17 UTC 2015
Nir Soffer has posted comments on this change.
Change subject: tests: FakeLVM add lvPath test
......................................................................
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/47863/5/tests/storagefakelibTests.py
File tests/storagefakelibTests.py:
Line 264: class FakeLVMGeneralTests(VdsmTestCase):
Line 265:
Line 266: def test_lvpath(self):
Line 267: with namedTemporaryDir() as tmpdir:
Line 268: lvm = FakeLVM(tmpdir)
Are we going to avoid the temporary directory here?
Seems that you need to introduce None support in FakeLVM before this patch.
Line 269: vg_name = 'foo'
Line 270: lv_name = 'bar'
Line 271: expected = os.path.join(tmpdir, 'dev', vg_name, lv_name)
--
To view, visit https://gerrit.ovirt.org/47863
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I46be518e68069412199dfb7ee44c7b7a8a207236
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list