Change in vdsm[master]: lib: utils: consolidate Error class in one place
nsoffer at redhat.com
nsoffer at redhat.com
Fri Nov 6 14:34:05 UTC 2015
Nir Soffer has posted comments on this change.
Change subject: lib: utils: consolidate Error class in one place
......................................................................
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/47964/5/lib/vdsm/cmdutils.py
File lib/vdsm/cmdutils.py:
Line 27:
Line 28: SUDO_NON_INTERACTIVE_FLAG = "-n"
Line 29:
Line 30:
Line 31: class Error(Exception):
> is that socket.error or socket.Error? Do we want to follow the same practic
socket.error is not pep8 compatible (class name should be CamelCase), we should not follow this detail.
Line 32:
Line 33: def __init__(self, rc, out, err):
Line 34: self.rc = rc
Line 35: self.out = out
--
To view, visit https://gerrit.ovirt.org/47964
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia490c055e6e5c637eba82ccffb9d2dfc748db8f5
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list