Change in vdsm[master]: gluster: Added VDSM verb to stop gluster related processes

barumuga at redhat.com barumuga at redhat.com
Fri Nov 6 08:28:35 UTC 2015


Bala.FA has posted comments on this change.

Change subject: gluster: Added VDSM verb to stop gluster related processes
......................................................................


Patch Set 4: Code-Review-1

(1 comment)

Please make yourself to -1 till the dependency patch gets merged in glusterfs.

https://gerrit.ovirt.org/#/c/43821/4/vdsm/gluster/api.py
File vdsm/gluster/api.py:

Line 771: stopProcesses(sel
Please change the name as ProcessesStop to be consistent with other verbs.  You should change it everywhere.  Sorry for the late review on this.


-- 
To view, visit https://gerrit.ovirt.org/43821
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id686e098b323eededcf1f89de331a1d524274995
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shubhendu Tripathi <shtripat at redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga at redhat.com>
Gerrit-Reviewer: Darshan Narayana Murthy <dnarayan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Ramesh N <rnachimu at redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose at redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtripat at redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list