Change in vdsm[master]: sampling: HostStatsThread as periodic operation

mzamazal at redhat.com mzamazal at redhat.com
Thu Nov 5 14:21:29 UTC 2015


Milan Zamazal has posted comments on this change.

Change subject: sampling: HostStatsThread as periodic operation
......................................................................


Patch Set 32: Code-Review-1

(6 comments)

https://gerrit.ovirt.org/#/c/40431/32/vdsm/virt/periodic.py
File vdsm/virt/periodic.py:

Line 102:             DriveWatermarkMonitor,
Line 103:             config.getint('vars', 'vm_watermark_interval')),
Line 104: 
Line 105:         Operation(
Line 106:             sampling.HostMonitor(cif.log, sampling.host_samples),
This doesn't match HostMonitor.__init__ arguments.
Line 107:             config.getint('vars', 'host_sample_stats_interval'))
Line 108: 
Line 109:     ]
Line 110: 


Line 107:             config.getint('vars', 'host_sample_stats_interval'))
Line 108: 
Line 109:     ]
Line 110: 
Line 111:     hoststats.start(clock)
`clock' undefined here.
Line 112: 
Line 113:     for op in _operations:
Line 114:         op.start()
Line 115: 


https://gerrit.ovirt.org/#/c/40431/32/vdsm/virt/sampling.py
File vdsm/virt/sampling.py:

Line 35
Line 36
Line 37
Line 38
Line 39
Unused.


Line 540
Line 541
Line 542
Line 543
Line 544
Still referred in samplingTests.py.


Line 541: 
Line 542: class HostMonitor(object):
Line 543:     _CONNLOG = logging.getLogger('connectivity')
Line 544: 
Line 545:     def __init__(self, samples=host_samples, clock=utils.monotonic_time):
What is `clock' here for?
Line 546:         self._samples = samples
Line 547: 
Line 548:         self._pid = os.getpid()
Line 549: 


Line 543:     _CONNLOG = logging.getLogger('connectivity')
Line 544: 
Line 545:     def __init__(self, samples=host_samples, clock=utils.monotonic_time):
Line 546:         self._samples = samples
Line 547: 
Extra empty line here.
Line 548:         self._pid = os.getpid()
Line 549: 
Line 550:     def __call__(self):
Line 551:         sample = HostSample(self._pid)


-- 
To view, visit https://gerrit.ovirt.org/40431
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I39c2e6e4bca286a513992b7231f1356e8dd871a1
Gerrit-PatchSet: 32
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: Roman Mohr <rmohr at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list