Change in vdsm[master]: Adding python3 run for nosetests

ybronhei at redhat.com ybronhei at redhat.com
Thu Nov 5 08:29:54 UTC 2015


Yaniv Bronhaim has posted comments on this change.

Change subject: Adding python3 run for nosetests
......................................................................


Patch Set 7:

(1 comment)

https://gerrit.ovirt.org/#/c/48051/7/lib/vdsm/utils.py
File lib/vdsm/utils.py:

Line 30: from collections import namedtuple, deque
Line 31: from contextlib import contextmanager
Line 32: from fnmatch import fnmatch
Line 33: try:
Line 34:     from StringIO import StringIO
> python 2.7 already has io.StringIO. If io.StringIO is safe for our usecase,
it fails with it. it doesn't contain len attribute
Line 35: except ImportError:
Line 36:     from io import StringIO
Line 37: from weakref import proxy
Line 38: from .compat import pickle


-- 
To view, visit https://gerrit.ovirt.org/48051
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I83355cce2af9125e6f017017905056956cd17081
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list