Change in vdsm[master]: tests: Add initial FakeLVM tests and fix errors

nsoffer at redhat.com nsoffer at redhat.com
Wed Nov 4 20:54:51 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: tests: Add initial FakeLVM tests and fix errors
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.ovirt.org/#/c/47857/3/tests/storagefakelibTests.py
File tests/storagefakelibTests.py:

Line 92: 
Line 93:     def test_vg_attributes(self):
Line 94:         expected = real_lvm.VG_ATTR(permission='w', resizeable='z',
Line 95:                                     exported='-', partial='-',
Line 96:                                     allocation='n', clustered='-')
This is much nicer - I can both the type of the object, and the value of the attributes.

Can we convert the previous test to use the same style?
Line 97:         with self.base_config() as lvm:
Line 98:             vg = lvm.getVG(self.VG_NAME)
Line 99:             self.assertEqual(expected, vg.attr)
Line 100: 


-- 
To view, visit https://gerrit.ovirt.org/47857
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1650b98f25df1a22ba2a0920b093e78fc2fdee88
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list