Change in vdsm[master]: lib: utils: consolidate Error class in one place

nsoffer at redhat.com nsoffer at redhat.com
Wed Nov 4 18:03:08 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: lib: utils: consolidate Error class in one place
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/47964/1/lib/vdsm/udevadm.py
File lib/vdsm/udevadm.py:

Line 23
Line 24
Line 25
Line 26
Line 27
> Referring the same class via different paths raises some red flags in my he
Good point. Lets avoid this issue by dropping udevadm.Error and taskset.Error, since we don't have a need for these error currently.

Instead, lets raise and handle cmdutils.Error everywhere. If we have a need later to handle specific errors differently, we can always add a subclass in some module.


-- 
To view, visit https://gerrit.ovirt.org/47964
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia490c055e6e5c637eba82ccffb9d2dfc748db8f5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list