Change in vdsm[master]: build: Introduce --enable-gluster-mgmt option

nsoffer at redhat.com nsoffer at redhat.com
Wed Nov 4 12:18:47 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: build: Introduce --enable-gluster-mgmt option
......................................................................


Patch Set 3:

(3 comments)

https://gerrit.ovirt.org/#/c/46708/3/vdsm.spec.in
File vdsm.spec.in:

Line 221: Requires: qemu-img >= 2:2.1.3-11
Line 222: %endif # rhel
Line 223: 
Line 224: # GlusterFS client-side RPMs needed for Gluster SD
Line 225: %if 0%{?with_gluster_mgmt}
> Shouldn't the glusterfs-cli and glusterfs-fuse be required even when with_g
They should, fixed in current version.
Line 226: Requires: glusterfs-cli >= %{gluster_version}
Line 227: Requires: glusterfs-fuse >= %{gluster_version}
Line 228: %endif
Line 229: 


Line 612: autoreconf -if
Line 613: %endif
Line 614: %configure %{?with_hooks:--enable-hooks} \
Line 615: %if 0%{?rhev_build}
Line 616:         --disable-gluster-mgmt \
> why is this required?
It is not, fixed in current version. There is no coupling now between rhev_build and gluster. One can build with or without gluster as needed.
Line 617:         --enable-rhev \
Line 618:         --with-smbios-manufacturer='Red Hat' \
Line 619:         --with-smbios-osname='RHEV Hypervisor' \
Line 620:         --with-qemu-kvm='qemu-kvm-rhev' \


https://gerrit.ovirt.org/#/c/46708/3/vdsm/gluster/__init__.py
File vdsm/gluster/__init__.py:

Line 34:     func.gluster_api = True
Line 35:     return func
Line 36: 
Line 37: 
Line 38: def listPublicFunctions(gluster_mgmt_enabledd=True):
> enabled or enabledd ?
Thanks, fixed in current version
Line 39:     methods = []
Line 40:     for modName in MODULE_LIST:
Line 41:         try:
Line 42:             module = __import__('gluster.' + modName, fromlist=['gluster'])


-- 
To view, visit https://gerrit.ovirt.org/46708
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I84608625e3b004c64b4928e5325d9375fb952878
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga at redhat.com>
Gerrit-Reviewer: Barak Korren <bkorren at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list