Change in vdsm[master]: virt: un-memoize getNumaTopology

fromani at redhat.com fromani at redhat.com
Wed Nov 4 09:01:26 UTC 2015


Francesco Romani has posted comments on this change.

Change subject: virt: un-memoize getNumaTopology
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

I reviewed the users of this function. It seems we don't have a choice, we must drop the memoziation in every place.

We can do some smart tricks to optimize the access to numa info, but let's save them for future patches.

https://gerrit.ovirt.org/#/c/48006/1/vdsm/caps.py
File vdsm/caps.py:

Line 303: 
Line 304: 
Line 305: def getNumaTopology(capabilities=None):
Line 306:     if capabilities is None:
Line 307:         capabilities = _getCapsXMLStr()
this is memoized as well, so we didn't gain that much.
Let's have this function call getFreshCapsXml if capabilities is None.
Line 308:     caps = ET.fromstring(capabilities)
Line 309:     host = caps.find('host')
Line 310:     cells = host.find('.//cells')
Line 311:     cellsInfo = {}


-- 
To view, visit https://gerrit.ovirt.org/48006
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3e28688fabf8fc18252b3a35dfdd9a5a4071685b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list