Change in vdsm[master]: netinfo, tool: make bonding defaults a proper Python module

ibarkan at redhat.com ibarkan at redhat.com
Wed Nov 4 06:03:18 UTC 2015


Ido Barkan has posted comments on this change.

Change subject: netinfo, tool: make bonding defaults a proper Python module
......................................................................


Patch Set 12:

Well, I agree that testing was a bit complex with the former implementation. But apart from that, what is so wrong in caching a json file? why should we need to replace this whole mechanism?

-- 
To view, visit https://gerrit.ovirt.org/33890
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic1f62c0052e42ea23cc06e64fc9e158bf5dc4258
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <toni+ovirt at midokura.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: No


More information about the vdsm-patches mailing list