Change in vdsm[ovirt-3.6]: Having logrotate configuration to rotate coredump directory ...

ybronhei at redhat.com ybronhei at redhat.com
Tue Nov 3 10:56:43 UTC 2015


Hello Dan Kenigsberg,

I'd like you to do a code review.  Please visit

    https://gerrit.ovirt.org/48003

to review the following change.

Change subject: Having logrotate configuration to rotate coredump directory as root user
......................................................................

Having logrotate configuration to rotate coredump directory as root user

As vdsm configures logrotate rule to rotate /var/log/core directory,
which output coredump files for all processes - such as once that runs
as root - it should perform the rotation as root user as well, otherwise
rotating libvirt coredump will be ignored with permission denied error.

This is an ancient regression introduced while fixing rhbz#772591 with
commit 951b41d.

Change-Id: Ib012f61a18c61bc0415be22f5b89ea25a58ef328
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1265547
Signed-off-by: Yaniv Bronhaim <ybronhei at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/47833
Continuous-Integration: Jenkins CI
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M vdsm/vdsm-logrotate.conf.in
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/03/48003/1

diff --git a/vdsm/vdsm-logrotate.conf.in b/vdsm/vdsm-logrotate.conf.in
index ce71015..af85330 100644
--- a/vdsm/vdsm-logrotate.conf.in
+++ b/vdsm/vdsm-logrotate.conf.in
@@ -15,5 +15,5 @@
     compresscmd /usr/bin/xz
     uncompresscmd /usr/bin/unxz
     compressext .xz
-    su @VDSMUSER@ @VDSMGROUP@
+    su root root
 }


-- 
To view, visit https://gerrit.ovirt.org/48003
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib012f61a18c61bc0415be22f5b89ea25a58ef328
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>


More information about the vdsm-patches mailing list