Change in vdsm[master]: sampling: HostSample always gets current cpus

fromani at redhat.com fromani at redhat.com
Tue Nov 3 08:12:24 UTC 2015


Francesco Romani has posted comments on this change.

Change subject: sampling: HostSample always gets current cpus
......................................................................


Patch Set 16:

(1 comment)

https://gerrit.ovirt.org/#/c/42035/16/vdsm/virt/sampling.py
File vdsm/virt/sampling.py:

Line 246:         """
Line 247:         super(HostSample, self).__init__()
Line 248:         self.interfaces = _get_interfaces_and_samples()
Line 249:         self.pidcpu = PidCpuSample(pid)
Line 250:         self.ncpus = max(os.sysconf('SC_NPROCESSORS_ONLN'), 1)
> Unlikely (to say the least), but here I just moved existing code. Will remo
Done in https://gerrit.ovirt.org/47991
Line 251:         self.totcpu = TotalCpuSample()
Line 252:         meminfo = utils.readMemInfo()
Line 253:         freeOrCached = (meminfo['MemFree'] +
Line 254:                         meminfo['Cached'] + meminfo['Buffers'])


-- 
To view, visit https://gerrit.ovirt.org/42035
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0e7d549b7772e3f38eec2dd9b91bbc6416b549bf
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: Roman Mohr <rmohr at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list