Change in vdsm[master]: lib: grub2 module

mpolednik at redhat.com mpolednik at redhat.com
Mon Nov 2 17:57:20 UTC 2015


Martin Polednik has posted comments on this change.

Change subject: lib: grub2 module
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/47946/1/lib/vdsm/grub2.py
File lib/vdsm/grub2.py:

Line 143:         if not val:
Line 144:             continue
Line 145:         workarounds.append(val)
Line 146: 
Line 147:     return workarounds
> could be a list comprehnsion
Not really, as split would introduce empty element.
Line 148: 
Line 149: 
Line 150: def _add_workaround(workarounds, workaround):
Line 151:     try:


-- 
To view, visit https://gerrit.ovirt.org/47946
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9e7e0b327882f64196a71fe20dcbd99017b80800
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list