Change in vdsm[master]: lib: grub2 module

mpolednik at redhat.com mpolednik at redhat.com
Mon Nov 2 12:59:38 UTC 2015


Martin Polednik has posted comments on this change.

Change subject: lib: grub2 module
......................................................................


Patch Set 1:

(2 comments)

Why do you see grub2-* as too low level?

https://gerrit.ovirt.org/#/c/47946/1/lib/vdsm/grub2.py
File lib/vdsm/grub2.py:

Line 22: import collections
Line 23: 
Line 24: from . import utils
Line 25: 
Line 26: _GRUB_CONFIG = os.path.abspath('/etc/default/grub')
> but this isn't already an abs path? :)
I'd say you're right, not really needed to normalize it I guess.
Line 27: 
Line 28: _CFG_NAME_PCI_STUB = 'VDSM_PCI_STUB_DEVICES'
Line 29: _CFG_NAME_WORKAROUNDS = 'VDSM_WORKAROUNDS'
Line 30: _CFG_NAME_CMDLINE = 'GRUB_CMDLINE_LINUX'


Line 32: 
Line 33: _GRUB2_MKCONFIG = utils.CommandPath('/usr/sbin/grub2-mkconfig')
Line 34: 
Line 35: 
Line 36: class Error(Exception):
> For another patch, not necessarily from yours: let's factor this Error copi
This is exactly what I'd like to see as I've seen it 3-or-so times lately.
Line 37: 
Line 38:     def __init__(self, rc, out, err):
Line 39:         self.rc = rc
Line 40:         self.out = out


-- 
To view, visit https://gerrit.ovirt.org/47946
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9e7e0b327882f64196a71fe20dcbd99017b80800
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list