Change in vdsm[master]: tests: functional - convert to run over jsonrpc

ykaplan at redhat.com ykaplan at redhat.com
Mon Nov 2 12:29:12 UTC 2015


Yeela Kaplan has posted comments on this change.

Change subject: tests: functional - convert to run over jsonrpc
......................................................................


Patch Set 10:

(1 comment)

https://gerrit.ovirt.org/#/c/45789/10/tests/functional/utils.py
File tests/functional/utils.py:

Line 165:         # add calling method for logs
Line 166:         test_method, code_line = stack[3][3], stack[3][2]
Line 167:         options['_caller'] = '{}:{}'.format(test_method, code_line)
Line 168:         result = self.vdscli.setupNetworks(networks, bonds, options, timeout=30)
Line 169:         return _parse_result(result)
> 15:16:34 ./tests/functional/utils.py:168:80: E501 line too long (80 > 79 ch
Done
Line 170: 
Line 171:     def _vlanInRunningConfig(self, devName, vlanId):
Line 172:         for net, attrs in self.config.networks.iteritems():
Line 173:             if (vlanId == attrs.get('vlan') and


-- 
To view, visit https://gerrit.ovirt.org/45789
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaba1e2811f010e4509a658acef8040ad8f39cece
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list