Change in vdsm[master]: init: configure multipath on upgrade from ovirt-3.5

ybronhei at redhat.com ybronhei at redhat.com
Mon Nov 2 10:08:31 UTC 2015


Yaniv Bronhaim has posted comments on this change.

Change subject: init: configure multipath on upgrade from ovirt-3.5
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/47941/1/init/vdsmd_init_common.sh.in
File init/vdsmd_init_common.sh.in:

Line 261:              ret=$?
Line 262:         elif grep -q '^vdsm-4\.16\.' "${upgraded_ver_file}"; then
Line 263:              # We need to treat the upgrade from 4.16.x specifically
Line 264:              # by running manual multipath configure command
Line 265:              "$VDSM_TOOL" configure --module multipath
> if we can avoid restarting libvirtd, I think that we should.
mmm right ... iirc --force won't configure libvirt if its already configured. anyhow - without --force also multipath will not be configured if it runs
Line 266:              ret=$?
Line 267:         fi
Line 268:         [ "${ret}" -eq 0 ] && rm -f "${upgraded_ver_file}"
Line 269:     fi


-- 
To view, visit https://gerrit.ovirt.org/47941
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifbebdebb6bda25606b20d91804977fa8eb7f13e8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Mooli Tayer <mtayer at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list