Change in vdsm[master]: net: fake sriov device hook

ibarkan at redhat.com ibarkan at redhat.com
Mon Nov 2 05:24:56 UTC 2015


Ido Barkan has posted comments on this change.

Change subject: net: fake sriov device hook
......................................................................


Patch Set 4:

(1 comment)

https://gerrit.ovirt.org/#/c/47847/4/vdsm_hooks/fakesriov/after_get_caps.py
File vdsm_hooks/fakesriov/after_get_caps.py:

Line 50:                   'hwaddr': 'ce:1f:0b:d1:ca:93', 'ipv4addrs': [],
Line 51:                   'ipv6addrs': [], 'ipv6gateway': '::', 'mtu': '1500',
Line 52:                   'netmask': '', 'speed': 0}}
Line 53: 
Line 54: if __name__ == '__main__':
> people tend to install hooks automatically, and then complain that their ho
done. I missed this in revision 2. fixed now.
Line 55:     caps = hooking.read_json()
Line 56:     caps.update(_PASSTHROUGH_SUPPORT)
Line 57:     caps['nics'].update(_NICS)


-- 
To view, visit https://gerrit.ovirt.org/47847
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic661e152adf6365962b5d9fd215277b36bc49383
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list