Change in vdsm[master]: net: bonding: validate options based on pre-dumped ones

danken at redhat.com danken at redhat.com
Sun May 31 13:12:53 UTC 2015


Dan Kenigsberg has posted comments on this change.

Change subject: net: bonding: validate options based on pre-dumped ones
......................................................................


Patch Set 4:

(1 comment)

https://gerrit.ovirt.org/#/c/41616/4/tests/netmodelsTests.py
File tests/netmodelsTests.py:

Line 92: self.assertEqual(Bond.validateOptions(opts), None)
> I can see this is the case in other tests too, but Bond.validateOptions nev
you can say so... though it is not really bad to verify that validate* function returns None.


-- 
To view, visit https://gerrit.ovirt.org/41616
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I03fce903280d5eda817e713a51c8079dab9d7649
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list