Change in vdsm[master]: RFE: Report downtime for each live migration

fromani at redhat.com fromani at redhat.com
Fri May 29 13:28:18 UTC 2015


Francesco Romani has posted comments on this change.

Change subject: RFE: Report downtime for each live migration
......................................................................


Patch Set 1:

(1 comment)

reverting score only for visibility, the patch is fine.

https://gerrit.ovirt.org/#/c/41415/1//COMMIT_MSG
Commit Message:

Line 7: RFE: Report downtime for each live migration
Line 8: 
Line 9: Migration.py returning donwtime_net instead of downtime.
Line 10: downtime returns actual vm downtime but the hosts need to be in sync,
Line 11: downtime_net return the same but don't need the hosts to be in sync.
codewise the patch is fine.

The problem here is that I know what this patch fixes, so I can follow what the commit message hints. Otherwise, it is a bit hard to understand.

Please rephrase the commit message providing more context, targeting someone which hasn't followed the discussion about downtime reporting.
Line 12: 
Line 13: Change-Id: Ie1cf80f5d41dadc95b814ea567e5c313ac6f25e2
Line 14: Bug-Url: https://bugzilla.redhat.com/970711


-- 
To view, visit https://gerrit.ovirt.org/41415
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie1cf80f5d41dadc95b814ea567e5c313ac6f25e2
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list