Change in vdsm[master]: status: adding elapsed time in millis

piotr.kliczewski at gmail.com piotr.kliczewski at gmail.com
Thu May 28 17:29:28 UTC 2015


Piotr Kliczewski has posted comments on this change.

Change subject: status: adding elapsed time in millis
......................................................................


Patch Set 8:

(1 comment)

https://gerrit.ovirt.org/#/c/40904/8/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 404:     def _notify(self, operation, params):
Line 405:         sub_id = '|virt|%s|%s' % (operation, self.id)
Line 406:         self.cif.notify(sub_id, **{self.id: params})
Line 407: 
Line 408:     def _get_status_time(self):
> I agree with Michal, this is infrastructure thing that should be added be t
Stomp header is not good place to have it there. I think that it should be part of a message body.
Line 409:         """
Line 410:         Value provided by this method is used to order messages
Line 411:         containing changed status on the engine side.
Line 412:         """


-- 
To view, visit https://gerrit.ovirt.org/40904
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I38727e0eac7cb29c1dc7c9696568540b6545461c
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list