Change in vdsm[master]: ifcfg: extract a helper function (_exec_ifup) from _ifup

danken at redhat.com danken at redhat.com
Thu May 28 12:27:53 UTC 2015


Dan Kenigsberg has submitted this change and it was merged.

Change subject: ifcfg: extract a helper function (_exec_ifup) from _ifup
......................................................................


ifcfg: extract a helper function (_exec_ifup) from _ifup

Originally, ifup contained the helper function and was able to run it
directly or in a thread (asynchronously, to avoid waiting on DHCP).

In order to be able to remove NetDevice's "async" (asynchronous_dhcp)
property, which (mostly) duplicates the blockingdhcp flag (which is
exposed as a part of VDSM's API) the descendant functions are now used
as follows:

  _exec_ifup is called when "async" was not used and

  _ifup now requires the "async" flag as a transitional step
  (it will be able to extract both a network device name and
   the flag from a NetDevice instance, as other configurators do)

Change-Id: I3c40cb09f05a0865b1942448a64fd37b735857f9
Signed-off-by: Ondřej Svoboda <osvoboda at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/40478
Continuous-Integration: Jenkins CI
Reviewed-by: Ido Barkan <ibarkan at redhat.com>
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M tests/configNetworkTests.py
M tests/netconfTests.py
M vdsm/network/configurators/ifcfg.py
3 files changed, 23 insertions(+), 25 deletions(-)

Approvals:
  Ido Barkan: Looks good to me, but someone else must approve
  Ondřej Svoboda: Verified
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/40478
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I3c40cb09f05a0865b1942448a64fd37b735857f9
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org


More information about the vdsm-patches mailing list