Change in vdsm[master]: gluster: create vg with custom pesize

tjeyasin at redhat.com tjeyasin at redhat.com
Thu May 28 11:03:33 UTC 2015


Timothy Asir has posted comments on this change.

Change subject: gluster: create vg with custom pesize
......................................................................


Patch Set 4:

(3 comments)

https://gerrit.ovirt.org/#/c/41392/4/vdsm/gluster/storagedev.py
File vdsm/gluster/storagedev.py:

Line 167:         return deviceList
Line 168: 
Line 169:     def _createVG(vgName, deviceList, stripeSize=0):
Line 170:         if stripeSize:
Line 171:             # bz#1198568:  Blivet creates vg with always 1MB stripe size
> %s/Blivet creates vg with always/Blivet always creates vg with/g
Done
Line 172:             # Workaround: Till the bz gets fixed, we use vgcreate command
Line 173:             devices = ','.join([device.path for device in deviceList])
Line 174:             rc, out, err = utils.execCmd([_vgCreateCommandPath.cmd,
Line 175:                                           '-s', '%sk' % stripeSize,


Line 168: 
Line 169:     def _createVG(vgName, deviceList, stripeSize=0):
Line 170:         if stripeSize:
Line 171:             # bz#1198568:  Blivet creates vg with always 1MB stripe size
Line 172:             # Workaround: Till the bz gets fixed, we use vgcreate command
> Replace the test as "Till blivet fixes the issue, use vgcreate command"
Done
Line 173:             devices = ','.join([device.path for device in deviceList])
Line 174:             rc, out, err = utils.execCmd([_vgCreateCommandPath.cmd,
Line 175:                                           '-s', '%sk' % stripeSize,
Line 176:                                           vgName, devices])


Line 171:             # bz#1198568:  Blivet creates vg with always 1MB stripe size
Line 172:             # Workaround: Till the bz gets fixed, we use vgcreate command
Line 173:             devices = ','.join([device.path for device in deviceList])
Line 174:             rc, out, err = utils.execCmd([_vgCreateCommandPath.cmd,
Line 175:                                           '-s', '%sk' % stripeSize,
> Do we always expect stripe size to be passed as 10k/20k etc ?
Default value would  be be 256 K, where as for raid devices it will be the strip size of the raid devices usually it will be in power of 2. Values may be 64k, 128k, 256k, 512k and so on
Line 176:                                           vgName, devices])
Line 177:             if rc:
Line 178:                 raise ge.GlusterHostStorageDeviceVGCreateFailedException(
Line 179:                     vgName, devices, stripeSize, rc, out, err)


-- 
To view, visit https://gerrit.ovirt.org/41392
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6ca89347b537e0ab6cffc2b1293ba9b5a32c366d
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Timothy Asir <tjeyasin at redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Darshan N <dnarayan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Ramesh N <rnachimu at redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose at redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtripat at redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list