Change in vdsm[master]: migration: Support SPICE seamless migration over NAT

mskrivan at redhat.com mskrivan at redhat.com
Thu May 28 10:01:35 UTC 2015


Michal Skrivanek has posted comments on this change.

Change subject: migration: Support SPICE seamless migration over NAT
......................................................................


Patch Set 4:

(1 comment)

https://gerrit.ovirt.org/#/c/41223/4/vdsm/virt/migration.py
File vdsm/virt/migration.py:

Line 348:             # TODO: use libvirt constants when bz#1222795 is fixed
Line 349:             params = {VIR_MIGRATE_PARAM_URI: str(muri),
Line 350:                       VIR_MIGRATE_PARAM_BANDWIDTH: maxBandwidth}
Line 351:             if self._consoleAddress:
Line 352:                 if self._vm.hasSpice:
> Do we have a way of knowing about this?
not easily. It's too much effort and not worth it. I'll document it in the bug as a known issue/behavior
Line 353:                     graphics = 'spice'
Line 354:                 else:
Line 355:                     graphics = 'vnc'
Line 356:                 params[VIR_MIGRATE_PARAM_GRAPHICS_URI] = \


-- 
To view, visit https://gerrit.ovirt.org/41223
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie7b2b765c62aaf1cc694990205b518558e808516
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list