Change in vdsm[master]: migration: Support SPICE seamless migration over NAT

fromani at redhat.com fromani at redhat.com
Thu May 28 08:19:24 UTC 2015


Francesco Romani has posted comments on this change.

Change subject: migration: Support SPICE seamless migration over NAT
......................................................................


Patch Set 4: Code-Review+1

(1 comment)

looks ok. Please verify with both spice and vnc.

https://gerrit.ovirt.org/#/c/41223/4/vdsm/virt/migration.py
File vdsm/virt/migration.py:

Line 353:                     graphics = 'spice'
Line 354:                 else:
Line 355:                     graphics = 'vnc'
Line 356:                 params[VIR_MIGRATE_PARAM_GRAPHICS_URI] = \
Line 357:                     str('%s://%s' % (graphics, self._consoleAddress))
minor nit: no need for both continuation ('\') and str(), you can write

  params[VIR_MIGRATE_PARAM_GRAPHICS_URI] = '%s://%s' % (
     graphics, self._consoleAddress)

Or, if the above doesn't fit in 79 columns:

  params[VIR_MIGRATE_PARAM_GRAPHICS_URI] = (
     '%s://%s' % (graphics, self._consoleAddress))
Line 358: 
Line 359:             flags = (libvirt.VIR_MIGRATE_LIVE |
Line 360:                      libvirt.VIR_MIGRATE_PEER2PEER |
Line 361:                      (libvirt.VIR_MIGRATE_TUNNELLED if


-- 
To view, visit https://gerrit.ovirt.org/41223
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie7b2b765c62aaf1cc694990205b518558e808516
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list