Change in vdsm[master]: vmfex_dev: unbreak migration

ibarkan at redhat.com ibarkan at redhat.com
Thu May 28 06:26:52 UTC 2015


Ido Barkan has posted comments on this change.

Change subject: vmfex_dev: unbreak migration
......................................................................


Patch Set 3: Code-Review-1

mixed feelings. it _should_ work, and Meni obviously confirms it. but isn't making attachProfileToInterfaceXml safer will handle the case we didn't think about (and tested) yet?
We could change attachProfileToInterfaceXml so that it would do no changes if they are not needed.

-- 
To view, visit https://gerrit.ovirt.org/41350
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I04cf4e635f6b70ef63af17b111841507af67a6da
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <toni+ovirt at midokura.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Meni Yakove <myakove at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: No


More information about the vdsm-patches mailing list