Change in vdsm[master]: status: adding elapsed time in millis
piotr.kliczewski at gmail.com
piotr.kliczewski at gmail.com
Wed May 27 18:36:24 UTC 2015
Piotr Kliczewski has posted comments on this change.
Change subject: status: adding elapsed time in millis
......................................................................
Patch Set 7:
(2 comments)
https://gerrit.ovirt.org/#/c/40904/7/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 407:
Line 408: """
Line 409: Value provided by this method is used to order messages
Line 410: containing changed status on the engine side.
Line 411: """
> Please put the docstring in the function.
Done
Line 412: def _get_status_time_in_millis(self):
Line 413: return int(round(utils.monotonic_time() * 1000))
Line 414:
Line 415: lastStatus = property(_get_lastStatus, _set_lastStatus)
Line 409: Value provided by this method is used to order messages
Line 410: containing changed status on the engine side.
Line 411: """
Line 412: def _get_status_time_in_millis(self):
Line 413: return int(round(utils.monotonic_time() * 1000))
> Why do you need to round the value?
Done
Line 414:
Line 415: lastStatus = property(_get_lastStatus, _set_lastStatus)
Line 416:
Line 417: def __getNextIndex(self, used):
--
To view, visit https://gerrit.ovirt.org/40904
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I38727e0eac7cb29c1dc7c9696568540b6545461c
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list