Change in vdsm[ovirt-3.5-gluster]: gluster:fix NoneType error for some devices does not contain...

tjeyasin at redhat.com tjeyasin at redhat.com
Wed May 27 06:31:35 UTC 2015


Timothy Asir has posted comments on this change.

Change subject: gluster:fix NoneType error for some devices does not contain sysfsPath
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/41466/1/vdsm/gluster/storagedev.py
File vdsm/gluster/storagedev.py:

Line 82:         # lvm vg will not have sysfs path
Line 83:         if hasattr(udev, 'get_device'):
Line 84:             dev = udev.get_device(device.sysfsPath) or {}
Line 85:         elif hasattr(udev, 'udev_get_device'):
Line 86:             dev = udev.udev_get_device(device.sysfsPath) or {}
> What is the bz?  And what is the bz for None value set to device.format.typ
bz#1223725. device.format.type discovery mechanism for xfs they are working on and is a known issue. bz#1209493 So that they have suggested to get it from udev if not appearing in device.format.type.
Line 87:         else:
Line 88:             dev = {}
Line 89:         info['fsType'] = device.format.type or dev.get('ID_FS_TYPE', '')
Line 90:     if hasattr(device.format, 'mountpoint'):


-- 
To view, visit https://gerrit.ovirt.org/41466
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I54efdf3958519e2ae038b527a03e0b57569c2e8f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5-gluster
Gerrit-Owner: Timothy Asir <tjeyasin at redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Darshan N <dnarayan at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Ramesh N <rnachimu at redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose at redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list