Change in vdsm[master]: gluster: use socket.getfqdn instead of 'hostname' binary

osvoboda at redhat.com osvoboda at redhat.com
Tue May 26 17:47:24 UTC 2015


Ondřej Svoboda has posted comments on this change.

Change subject: gluster: use socket.getfqdn instead of 'hostname' binary
......................................................................


Patch Set 4:

(1 comment)

Restored logging (previously done by _execCmd).

https://gerrit.ovirt.org/#/c/37621/4/vdsm/gluster/cli.py
File vdsm/gluster/cli.py:

Line 128: 
Line 129: def _getGlusterHostName():
Line 130:     try:
Line 131:         return socket.getfqdn()
Line 132:     except socket.herror:
> add
Done
Line 133:         return ''
Line 134: 
Line 135: 
Line 136: @makePublic


-- 
To view, visit https://gerrit.ovirt.org/37621
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4b4a0062bedc41bee6528c1d06d707b4f7547e6
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Darshan N <dnarayan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list