Change in vdsm[master]: vm: Detect smartcard device by type

smelamud at redhat.com smelamud at redhat.com
Tue May 26 13:09:37 UTC 2015


Hello Shmuel Melamud,

I'd like you to do a code review.  Please visit

    https://gerrit.ovirt.org/41479

to review the following change.

Change subject: vm: Detect smartcard device by type
......................................................................

vm: Detect smartcard device by type

Use 'type' instead of 'device' to detect smartcard devices. For
consistency, devices that don't really use 'device' attribute must be
detected by 'type'.

Change-Id: Ib81116942baf31a0625e095c439b30d2d2cc9f54
Signed-off-by: Shmuel Melamud <smelamud at redhat.com>
---
M vdsm/virt/vm.py
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/79/41479/1

diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index d918094..63955f4 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -3843,7 +3843,7 @@
                     dev.alias = alias
 
             for dev in self.conf['devices']:
-                if dev['device'] == hwclass.SMARTCARD and \
+                if dev['type'] == hwclass.SMARTCARD and \
                         not dev.get('address'):
                     dev['address'] = address
                     dev['alias'] = alias


-- 
To view, visit https://gerrit.ovirt.org/41479
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib81116942baf31a0625e095c439b30d2d2cc9f54
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shmuel Leib Melamud <smelamud at redhat.com>
Gerrit-Reviewer: Shmuel Melamud <smelamud at redhat.com>


More information about the vdsm-patches mailing list