Change in vdsm[master]: virt: remove duplicate connection in hostdevTests

fromani at redhat.com fromani at redhat.com
Tue May 26 12:34:15 UTC 2015


Francesco Romani has posted comments on this change.

Change subject: virt: remove duplicate connection in hostdevTests
......................................................................


Patch Set 1: Code-Review+1

cool, I like the concept.

Please note that I'm *not* religiously against duplicating fakes outside vmfakelib. I just need we need clear and strong cases for such duplication, and try hard to be DRY in the common case.

-- 
To view, visit https://gerrit.ovirt.org/40946
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I936766c8fd4c87175dcc3987d7ae5c64ff5675ea
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: No


More information about the vdsm-patches mailing list