Change in vdsm[master]: stomp: creation of outbox class

ybronhei at redhat.com ybronhei at redhat.com
Tue May 26 11:59:10 UTC 2015


Yaniv Bronhaim has posted comments on this change.

Change subject: stomp: creation of outbox class
......................................................................


Patch Set 6: Code-Review-1

I asked for that Outbox after seeing that in https://gerrit.ovirt.org/#/c/36368/25 you implement twice peek,pop, queue functions in stomp and in stompreactor - so to avoid it I advice to remove those and have Outbox object as property - now we have both. so either remove the outbox or remove the duplication in the following patch

-- 
To view, visit https://gerrit.ovirt.org/41067
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2020b05393daeafaed73f628cf441305a2d52354
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: No


More information about the vdsm-patches mailing list