Change in vdsm[master]: RFE: Report downtime for each live migration

fromani at redhat.com fromani at redhat.com
Tue May 26 06:42:53 UTC 2015


Francesco Romani has posted comments on this change.

Change subject: RFE: Report downtime for each live migration
......................................................................


Patch Set 9:

(2 comments)

looks OK, but commit message needs to be updated.

https://gerrit.ovirt.org/#/c/40103/9//COMMIT_MSG
Commit Message:

Line 9: vm.py getStat() is called when migration is done and from Engine
Line 10: initiative.
Line 11: 
Line 12: There is no need to call libvirts domain getStats twice, only when
Line 13: Engine initiate the call.
can you elaborate about how this reflects in the changes you made into migration.py?
Line 14: 
Line 15: Change-Id: I2ff421c489ef24869502bd80461018f0aca2144d
Line 16: Bug-Url: https://bugzilla.redhat.com/970711


https://gerrit.ovirt.org/#/c/40103/9/vdsm/API.py
File vdsm/API.py:

Line 352:         try:
Line 353:             v = self._cif.vmContainer[self._UUID]
Line 354:         except KeyError:
Line 355:             return errCode['noVM']
Line 356:         return {'status': doneCode, 'migrationStats': v.migrateStatus()}
this - and the Bridge.py counterpart - looks like a separate change squashed inside this one. If it is not, please add a few lines in the commit message explaining the interdependencies.
Line 357: 
Line 358:     def getStats(self):
Line 359:         """
Line 360:         Obtain statistics of the specified VM


-- 
To view, visit https://gerrit.ovirt.org/40103
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2ff421c489ef24869502bd80461018f0aca2144d
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list